Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in calculation of c02900 #1977

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix bug in calculation of c02900 #1977

merged 1 commit into from
Apr 19, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request removes two statements in the CapGains function that should have been removed as part of pull request #1899, which was merged on March 7, 2018, and first included in Tax-Calculator version 0.16.2, which was released on March 9, 2018. My failure to remove those lines caused the bug reported in issue #1975, which was raised by @evtedeschi3 on April 18, 2018.

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #1977 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1977   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3755    3755           
======================================
  Hits         3755    3755

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f978987...48f83cc. Read the comment docs.

@martinholmer martinholmer merged commit 98e570c into PSLmodels:master Apr 19, 2018
@martinholmer martinholmer deleted the fix-c02900-bug branch April 19, 2018 22:01
@martinholmer martinholmer removed the ready label May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants