Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three ALD amounts to expanded_income #1899

Merged
merged 4 commits into from
Mar 7, 2018
Merged

Add three ALD amounts to expanded_income #1899

merged 4 commits into from
Mar 7, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Mar 2, 2018

This pull request is the second in a series beginning with #1897.
It consists of the three commits 85c63eb and 27acb6b and 98ab493.

This pull request fixes the calculation of expanded_income by correcting the omission of three ALD amounts. The current logic used to compute expanded_income is convoluted: in part it adds to AGI several amounts that were subtracted from income to get AGI. We plan to replace this convoluted logic in a subsequent pull request. But before doing that we are attempting to fix the convoluted logic so that the reasons for and the magnitudes of the errors in the current expanded_income logic are clear.

The three ALD variables and their 2011 PUF amounts (which were missing from expanded_income) are as follows:

Variable 2011 Amt($b) Description
e03270 25 Self-employed health insurance
e03150 11 IRA contribution
e03300 19 Keogh-SEP contribution

This pull request also fixes the difference table calculation logic so that nan amounts are shown as zeros.

@codecov-io
Copy link

codecov-io commented Mar 2, 2018

Codecov Report

Merging #1899 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1899   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3369    3371    +2     
======================================
+ Hits         3369    3371    +2
Impacted Files Coverage Δ
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a23bd...c4c75fb. Read the comment docs.

@martinholmer martinholmer merged commit ec5575c into PSLmodels:master Mar 7, 2018
@martinholmer martinholmer deleted the fix-expanded-income2 branch March 7, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants