Skip to content

Commit

Permalink
Prepend kiss_icp_ for env variable usage
Browse files Browse the repository at this point in the history
Before this didn't work
```
export DATA=carlos
kiss_icp_pipeline ...
```

After, you need to be more explicit to break it:
```
export KISS_ICP_DATA=carlos
kiss_icp_pipeline ...
```

This allow us to mantain the API as well
  • Loading branch information
nachovizzo committed Mar 1, 2024
1 parent 44d8563 commit ba9a15b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion python/kiss_icp/config/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@
from pathlib import Path
from typing import Any, Dict, Optional

from pydantic_settings import BaseSettings
from pydantic_settings import BaseSettings, SettingsConfigDict

from kiss_icp.config.config import AdaptiveThresholdConfig, DataConfig, MappingConfig


class KISSConfig(BaseSettings):
model_config = SettingsConfigDict(env_prefix="kiss_icp_")
out_dir: str = "results"
data: DataConfig = DataConfig()
mapping: MappingConfig = MappingConfig()
Expand Down

0 comments on commit ba9a15b

Please sign in to comment.