Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute phpcs and security-checker from vendor/bin #52

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Execute phpcs and security-checker from vendor/bin #52

merged 2 commits into from
Sep 9, 2018

Conversation

gapple
Copy link
Contributor

@gapple gapple commented Jul 12, 2018

Proposed Changes

sensiolabs/security-checker introduced a change in 4.1.6 that makes the phar only compatible with PHP 7.1+

  1. Use composer to manage the required version of security-checker instead of downloading via curl
  2. Execute phpcs and security-checker from /vendor/bin instead of the phar files.

Related Issues

@jrfnl jrfnl mentioned this pull request Sep 7, 2018
Merged
@frenck frenck merged commit 4259d3a into PHPCSStandards:master Sep 9, 2018
@gapple gapple deleted the composer-bin branch June 3, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
builds / deploys / releases
Projects
None yet
Milestone
Release v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gapple @frenck @Potherca