-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The composer plugin implementation seems to be breaking the composer lifecycle #49
Comments
This is still causing me problems on a couple of projects I'm working on. Please, check out how it can be fixed or discuss a possible solution with composer maintainer (Jordi Boggiano). Thanks a lot, |
the culprit is https://github.com/Dealerdirect/phpcodesniffer-composer-installer/blob/2e41850d5f7797cbb1af7b030d245b3b24e63a08/src/Plugin.php#L121 which is running phpcs when initializing the plugin, and so expects the vendor folder to be in a working state at that time, including the dumped autoloader (which is not guaranteed at all by composer, almost the opposite) |
Looks like PR #51 addresses this issue. |
Related GH-48 |
In order to use the fix from PR #51 commited to Some of us needs to update the package with composer and latest master-dev is not allowed by restrictions of other dependent packages. I've created a new issue with a request of new stable release #60 |
Merged in #51, I'll consider a release within the next couple of days (some cleanup on this repo in progress). |
Problem
The
dealerdirect/phpcodesniffer-composer-installer
version0.4.4
(currently latest version) is probably breaking composer lifecycle.Here is a link to composer issue: composer/composer#7298 (comment) where the Jordi Boggiano (the author of composer) and I have come to a conclusion that there may be a bug in this package.
Please, read the issue composer/composer#7298, mainly the comment composer/composer#7298 (comment), it contains all the details I was able to collect.
Expected behaviour
The
composer update
orcomposer require
should not crash in the custom installer implemented by this package while trying to use autoloader that is not yet regenerated and is in a stale state (not updated yet).The text was updated successfully, but these errors were encountered: