-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Travis-CI configuration file. #27
Conversation
.travis.yml
Outdated
- npm set progress false | ||
|
||
install: | ||
- composer global require "dealerdirect/qa-tools:*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the dealerdirect/qa-tools
also requires this plugin AND is installed globally, the globally installed instance of the plugin will be used.
Please see the Caveats section of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a1d749e
to
18f322e
Compare
…-tools" globally - Uses PHAR files instead of `composer global` install - Adds PHAR cache and monthly cleanup - Uses `php -l` instead of `parallel-lint` package
18f322e
to
0ca1f2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1
Proposed Changes
I got annoyed at all of the pull-requests having a red ❌ next to builds.
This merge request fixes that by adding a
.travis.yml
file that triggers a PHP build.It tries to find a balance between speed and quality.
I've also added a fix for a PHP CodeSniffer violation (one line exceeded 120 characters).
Related Issues
Part of issue #9
Caveats
The
dealerdirect/qa-tools
is installed on the Travis machine to run QA checks.Currently this means the build for unsupported PHP versions (5.3, 5.4, 5.4) will fail because
qa-tools
requires at least 5.6.At a later stage, these builds could be made to pass. Such a solution is not within scope for this merge-request.