Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Travis-CI configuration file. #27

Merged
merged 4 commits into from
May 10, 2017
Merged

Adds Travis-CI configuration file. #27

merged 4 commits into from
May 10, 2017

Conversation

Potherca
Copy link
Member

Proposed Changes

I got annoyed at all of the pull-requests having a red ❌ next to builds.

This merge request fixes that by adding a .travis.yml file that triggers a PHP build.
It tries to find a balance between speed and quality.

I've also added a fix for a PHP CodeSniffer violation (one line exceeded 120 characters).

Related Issues

Part of issue #9

Caveats

The dealerdirect/qa-tools is installed on the Travis machine to run QA checks.
Currently this means the build for unsupported PHP versions (5.3, 5.4, 5.4) will fail because qa-tools requires at least 5.6.

At a later stage, these builds could be made to pass. Such a solution is not within scope for this merge-request.

@Potherca Potherca added this to the v0.4.0 milestone May 10, 2017
@Potherca Potherca requested a review from frenck May 10, 2017 08:36
.travis.yml Outdated
- npm set progress false

install:
- composer global require "dealerdirect/qa-tools:*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the dealerdirect/qa-tools also requires this plugin AND is installed globally, the globally installed instance of the plugin will be used.

Please see the Caveats section of the documentation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patrick

Yeah... I must have not been thinking straight (or too lazy).

Will improve the merge-request to fix this.

@Potherca Potherca force-pushed the issue/9/travis-ci branch 3 times, most recently from a1d749e to 18f322e Compare May 10, 2017 11:58
…-tools" globally

- Uses PHAR files instead of `composer global` install
- Adds PHAR cache and monthly cleanup
- Uses `php -l` instead of `parallel-lint` package
@Potherca Potherca force-pushed the issue/9/travis-ci branch from 18f322e to 0ca1f2b Compare May 10, 2017 12:00
Copy link
Contributor

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@Potherca Potherca merged commit 221b57a into master May 10, 2017
@Potherca Potherca deleted the issue/9/travis-ci branch May 10, 2017 12:27
@frenck frenck mentioned this pull request May 10, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants