Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit tests and CI #9

Closed
2 of 3 tasks
frenck opened this issue Feb 5, 2017 · 7 comments · Fixed by #153
Closed
2 of 3 tasks

Add PHPUnit tests and CI #9

frenck opened this issue Feb 5, 2017 · 7 comments · Fixed by #153

Comments

@frenck
Copy link
Contributor

frenck commented Feb 5, 2017

Motivation

The user base of this plugin seems to grow, which is awesome but we need to maintain its quality, while also being able to accept PR's.

Proposed changes

PHPUnit tests for this plugin and Travis CI running them on every single commit and/or PR.

  1. Create PHPUnit tests.
  2. Configure Travis CI with this repository (resolved by Adds Travis-CI configuration file. #27).
  3. Force repository setting to require successful builds on PR's.
@Potherca
Copy link
Member

Potherca commented Feb 5, 2017

I'll pick up writing unit tests.

@christopher-hopper
Copy link
Contributor

I can assist with the Travis CI integration. I have recent experience on this using Appveyor (Windows) and CircleCI. Agree that Travis is the best option for this project.

@frenck
Copy link
Contributor Author

frenck commented Feb 6, 2017

@christopher-hopper Thank you for your offer.

I think it would be wise for us to first setup the basics with our Travis CI account ourselves, afterwards your are of course welcome to improve 🥇

@frenck frenck removed the help wanted label Feb 6, 2017
@frenck
Copy link
Contributor Author

frenck commented Feb 15, 2017

Related to this issue:

I've added Scrutinizer to this repository.

@Potherca
Copy link
Member

Travis and PR-build have been resolved.

@jrfnl
Copy link
Member

jrfnl commented Sep 7, 2018

Just wondering: Should these tests be run in combination with various PHPCS versions ?

@Potherca
Copy link
Member

Potherca commented May 7, 2019

I've got time to look into this in the coming weeks. Will report progress when I make it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants