Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DefaultMappingStrategy from http-problem-details-mapper #19

Merged

Conversation

AlexZeitler
Copy link
Contributor

As discussed in #15

BREAKING CHANGE: `DefaultMappingStrategy` from `http-problem-details-mapper` or your own implementation of `IMappingStrategy` / `MappingStrategy` has to be used now.
there are no tests at the moment
@AlexZeitler
Copy link
Contributor Author

@tpluscode Does it look good to you?

@AlexZeitler AlexZeitler changed the title WIP: use DefaultMappingStrategy from http-problem-details-mapper Use DefaultMappingStrategy from http-problem-details-mapper Nov 18, 2019
Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexZeitler AlexZeitler merged commit 6d30ac1 into PDMLab:master Nov 21, 2019
@AlexZeitler AlexZeitler deleted the remove-express-mapping-strategy branch November 21, 2019 10:12
@AlexZeitler
Copy link
Contributor Author

@tpluscode Thanks, 📦 0.2.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants