Does ExpressMappingStrategy belong here?

[tpluscode]

I'm not sure how specific the ExpressMappingStrategy is to express actually?

I think right now that maybe it belongs to the http-problem-details-mapper package.

[AlexZeitler]

Currently it is not tied to express.

It is same as the HapiMappingStrategy here.

And even if someone would have the need to make it depend on express related stuff, it would still be possible by implementing a custom IMappingStrategy.

[tpluscode]

My point was only that maybe the default implementation could be moved to the upstream packages. Just a thought

[AlexZeitler]

Yes, I understood it that way and I wanted to express I agree with that 😄

[AlexZeitler]

Do you want to send a PR here or should I do it?

Would you mind reviewing the PRs then?

I would suggest it should be named DefaultMappingStrategy as abstract class MappingStrategy already exists in http-problem-details-mapper.

[tpluscode]

👍 to the name but I would also move the implementation to the mapper package.

[AlexZeitler]

Yes, from my understanding we already have committed to move it to the mapper package.

[tpluscode]

Right, right. This is not a high priority for me right now. Go ahead and I will gladly review. Otherwise maybe can try over the weekend.

[AlexZeitler]

No worries, I can do it. I just wanted to avoid misunderstandings.

[AlexZeitler]

This is the PR for http-problem-details-mapper:
PDMLab/http-problem-details-mapper#14