Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #42

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Fix failing tests #42

merged 2 commits into from
Jul 5, 2018

Conversation

robertblank
Copy link
Contributor

The following tests were fixed

  • \Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__handlePayPalExpressCall_Coverage
  • \Unit_fcPayOne_Extend_Application_Controllers_fcPayOnePaymentView::test_fcpoGetPayolutionAgreementLink_Coverage

@PirxDanford PirxDanford mentioned this pull request Jun 26, 2018
Closed
@fjbender fjbender requested a review from andrefatchip June 27, 2018 05:53
@andrefatchip
Copy link
Collaborator

These PR seems valid to me. Ironically at some point I also set the base64 encoded companyname into the test, but in this case the test failed as long as I did not set this companyname into config. However I'm fine with the solution provided due to it helps passing the tests.

@fjbender fjbender merged commit 1a888ab into PAYONE-GmbH:master Jul 5, 2018
@fjbender
Copy link
Contributor

fjbender commented Jul 5, 2018

Thanks for your help here, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjbender fjbender fjbender approved these changes

@andrefatchip andrefatchip Awaiting requested review from andrefatchip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertblank @andrefatchip @fjbender