Tests are failing on version 1.0.7

[MantasVaitkunas]

I tried to run tests with module v1.0.7 and OXID eShop compilation v6.0.1 and got some failures:

vendor/bin/runtests
1) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__fcpoHandlePaypalExpressUser_RemoveAddressFromSession
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_fcPayOneUser_3756d52c)
2) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__fcpoHandlePaypalExpressUser_CreatePaypalDelAddress
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_fcPayOneUser_3756d52c)
3) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__fcpoHandlePaypalExpressUser_ThrowException
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_fcPayOneUser_3756d52c)
4) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__fcpoHandlePaypalExpressUser_CreatePaypalAddress
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_fcPayOneUser_3756d52c)
5) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__handlePayPalExpressCall_Coverage
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_DeliverySet_612589a8)

[PirxDanford]

Hi, additionally to the above Errors there was also one Failure:

1) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__fcpoDoesPaypalUserAlreadyExist_Coverage
Failed asserting that false matches expected 'someUserId'.

Is there any progress on this issue?

[fjbender]

Not yet, we're still working on this.

[PirxDanford]

Hi, as our regular maintenance release (eShop compilation v6.0.3) is coming up end of July it would be very good if we could bump up from using v1.0.5. Any progress?

[fjbender]

Can you confirm that the tests pass with #38 merged? Then I'll bump up the version.

[fjbender]

Version bump will follow once #39 is merged.

[PirxDanford]

Hi,
sadly with 1.0.8 we still see this one error:

1) Unit_fcPayOne_Extend_Application_Controllers_fcPayOneOrderView::test__handlePayPalExpressCall_Coverage
OxidEsales\Eshop\Core\Exception\SystemComponentException: Function 'fcpoDoesUserAlreadyExist' does not exist or is not accessible! (Mock_DeliverySet_e958571e)

and one failure is new:

1) Unit_fcPayOne_Extend_Application_Controllers_fcPayOnePaymentView::test_fcpoGetPayolutionAgreementLink_Coverage
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'https://payment.payolution.com/payolution-payment/infoport/dataprivacydeclaration?mId=&lang=someAbbr&territory=DE'
+'https://payment.payolution.com/payolution-payment/infoport/dataprivacydeclaration?mId=c29tZUNvbXBhbnk=&lang=someAbbr&territory=DE'

We might have a solution for the error, if so I'll make sure a pull request is provided. For the failure please have a look at how to solve this and if it is sufficient to provide the changed URL in the test.

[PirxDanford]

We now have provided a pull request (#42). As this is only about test coverage we still can take v1.0.8 for the next release, so no need to hurry.

[fjbender]

Thanks, we'll review

[PirxDanford]

Just noticed this has not been closed yet - thanks for taking the pull request :-)

[hreinberger]

Thanks for the notice (and the PR of course)!