Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detection for CVE-2024-47575 #137
Add detection for CVE-2024-47575 #137
Changes from all commits
1ad88ac
557d119
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 88 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L83-L88
Check warning on line 91 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L90-L91
Check warning on line 97 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L93-L97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we add an error logging here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Check warning on line 103 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L102-L103
Check warning on line 105 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L105
Check warning on line 110 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L109-L110
Check warning on line 114 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L112-L114
Check warning on line 159 in agent/exploits/cve_2024_47575.py
Codecov / codecov/patch
agent/exploits/cve_2024_47575.py#L158-L159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using list if we only append one vulnerability? if we need it to be a list maybe we can do `return [vulnerability]? and can we return directly without appending? since it seem that we only return once
Check warning on line 27 in tests/exploits/cve_2024_47575_test.py
Codecov / codecov/patch
tests/exploits/cve_2024_47575_test.py#L27
Check warning on line 64 in tests/exploits/cve_2024_47575_test.py
Codecov / codecov/patch
tests/exploits/cve_2024_47575_test.py#L64