Add detection for CVE-2024-47575 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiranhaSa
reviewed
Nov 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 96.46% 96.13% -0.34%
==========================================
Files 176 178 +2
Lines 6287 6393 +106
==========================================
+ Hits 6065 6146 +81
- Misses 222 247 +25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rabsondev
reviewed
Nov 20, 2024
rabsondev
reviewed
Nov 20, 2024
3asm
requested changes
Nov 20, 2024
rabsondev
reviewed
Nov 20, 2024
rabsondev
reviewed
Nov 20, 2024
ohachimOs
reviewed
Nov 20, 2024
Comment on lines
+155
to
+161
| if remote_id != "": | ||
| vulnerability = self._create_vulnerability(target) | ||
| vulnerabilities.append(vulnerability) | ||
| except (UnicodeDecodeError, IndexError, ValueError): | ||
| return vulnerabilities | ||
|
|
||
| return vulnerabilities |
There was a problem hiding this comment.
why are we using list if we only append one vulnerability? if we need it to be a list maybe we can do `return [vulnerability]? and can we return directly without appending? since it seem that we only return once
Comment on lines
+96
to
+97
| except TimeoutError: | ||
| return b"" |
There was a problem hiding this comment.
shouldn't we add an error logging here?
3asm
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces detection logic for CVE-2024-47575, a critical vulnerability in FortiManager caused by missing authentication for critical functions.
Detection Mechanism
The
checkfunction performs the following steps to determine if the target is vulnerable:get ipandget authrequests to establish the session.get file_exchangerequest includes a non-emptyremoteidvalue, the target is identified as vulnerable, and a finding is reported.remoteidis missing or empty, no vulnerabilities are reported.