Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline tenant status #7987

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Inline tenant status #7987

merged 3 commits into from
Dec 14, 2020

Conversation

hishamco
Copy link
Member

No description provided.

@hishamco hishamco mentioned this pull request Dec 14, 2020
Closed
@agriffard
Copy link
Member

Nice, I like it.

Can you add a title="@T[...]" with the state and use fa-xs?

@hishamco
Copy link
Member Author

I forgot the title, also I was looking for something like fa-xs ;)

Thanks

@hishamco
Copy link
Member Author

Seems localization will enforce me to return the switch back :(

@agriffard
Copy link
Member

May be init the variable cssClass and state in one switch and then use them in the html.

@hishamco
Copy link
Member Author

May be init the variable cssClass and state in one switch and then use them in the html.

It will nothing the localization extractor will unable to find them, while they are dynamic

@hishamco hishamco closed this Dec 14, 2020
@hishamco hishamco reopened this Dec 14, 2020
@agriffard agriffard merged commit 567185d into dev Dec 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the hishamco/tenants-status branch December 14, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamco @agriffard