Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenants States #7971

Closed
wants to merge 6 commits into from
Closed

Tenants States #7971

wants to merge 6 commits into from

Conversation

agriffard
Copy link
Member

Display the State on the title line.

Purpose: Display 10 tenants and show the pager without having to scroll.

image

@hishamco
Copy link
Member

Show the badge underneath will looks better

@agriffard
Copy link
Member Author

Show the badge underneath will looks better

By underneath, do you mean below?

My goal is to condense the display.

@hishamco
Copy link
Member

By underneath, do you mean below?

Yes, coz the status in the badge are not equal in terms of characters length, that's why I see the UI is need to be organized little bit

@agriffard
Copy link
Member Author

Between title and url:

image

@Skrypt
Copy link
Contributor

Skrypt commented Dec 13, 2020

How about using a grid here with a col-4 which would collapse on md breakpoint to col-md-12?
I think these details needs to be enhanced pretty much everywhere.

@Skrypt
Copy link
Contributor

Skrypt commented Dec 13, 2020

Again here let's just see what Github does :

image

They use icons for "status" which makes them equals. Also, the text of the content item never wraps underneath a checkbox or icon. Which means these a defined columns in a grid. And if you resize your window you will see that they hide some content too.

@hishamco
Copy link
Member

We can move them below as we already did in content items or use circle icons as @Skrypt suggested

@agriffard
Copy link
Member Author

image

@agriffard agriffard requested a review from hishamco December 14, 2020 09:05
@hishamco
Copy link
Member

@agriffard this could be simplfied by #7987

@agriffard
Copy link
Member Author

Replaced by #7987

@agriffard agriffard closed this Dec 14, 2020
@agriffard agriffard deleted the ag/tenantsStates branch October 5, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants