fix(motor-control): adding back the removed delay to allow ebrake to fully disegnage #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Oct 8, 2024
ahiuchingau
force-pushed
the
RQA-3290-bug-stall-while-detaching-96-ch
branch
from
e499ca8 to
ef7b0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix the z stage free-falling issue (see #804), I had moved the delay before the ebrake so that the motor current has a chance to ramp up. As a result, the ebrake now doesn't have enough time to disengage before the motor is commanded to move so now the z stage would stall occasionally. So I'm adding more delay - so now it delays after enabling the motor, and delays again after the brake is disengaged.