Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hepa-uv): Set the UV pushbutton status led correctly. #759

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Mar 19, 2024

Overview

The UV pushbutton status LED is set to "User Intervention" (Blue) whenever the Flex door is opened, However, according to the Hepa/UV status-led design document here, we ONLY want to set this status when the user ATTEMPTS to turn ON the UV light while the door is open.

Closes: PLAT-260

Test Plan

  • Make sure that the UV indicator LED turns Green when the UV pushbutton is pressed and the UV light is turned ON while the Flex door is closed.
  • Make sure that the UV indicator LED turns White when the UV pushbutton is pressed again and the UV light is turned OFF while the Flex door is closed.
  • Make sure that the UV indicator LED turns Blue when the UV pushbutton is pressed while the Flex door is open.
  • Make sure that the UV indicator LED turns Blue when the Flex door is opened WHILE the UV cycle is running.

Change Log

  • Only set the intervention state (Blue) when attempting to turn on the UV light while the Flex door is open.

Review Requests

Risk Assessment

Low, unreleased

@vegano1 vegano1 requested a review from ahiuchingau March 19, 2024 03:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (b11fd3d) to head (f9c5e87).
Report is 3 commits behind head on PLAT-246-send-an-error-message-when-the-door-input-shuts-off-the-light.

Additional details and impacted files

Impacted file tree graph

@@                                           Coverage Diff                                           @@
##           PLAT-246-send-an-error-message-when-the-door-input-shuts-off-the-light     #759   +/-   ##
=======================================================================================================
  Coverage                                                                   83.28%   83.28%           
=======================================================================================================
  Files                                                                         101      101           
  Lines                                                                        4063     4063           
=======================================================================================================
  Hits                                                                         3384     3384           
  Misses                                                                        679      679           

Base automatically changed from PLAT-246-send-an-error-message-when-the-door-input-shuts-off-the-light to main March 19, 2024 14:00
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡

@vegano1 vegano1 merged commit a6476b3 into main Mar 19, 2024
31 checks passed
@vegano1 vegano1 deleted the PLAT-260_uv-led-status-fix branch March 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants