fix 2160 motor driver register usage #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 101 101
Lines 4044 4044
=======================================
Hits 3380 3380
Misses 664 664 |
sfoster1
approved these changes
Feb 21, 2024
ahiuchingau
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Nice catch. I don't think it's being used anywhere, could you verify that @pmoegenburg?
|
Confirmed this method isn't being used anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the 2160 motor driver register we use with the
update_glob_scalermethod.