fix(gripper): add GripperJawStateRequest to gripper can task & do not disable brushed motor if it was set to stay engaged #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fsinapi
approved these changes
Sep 11, 2023
| } | ||
| if (hardware.is_timer_interrupt_running()) { | ||
| hardware.request_cancel(); | ||
| if (hardware.is_timer_interrupt_running()) { |
There was a problem hiding this comment.
Can this change make its way into the PR description please?
caila-marashaj
approved these changes
Sep 11, 2023
ahiuchingau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this to the can task so we weren't getting any response back from the gripper.
Testing is importante!