refactor(api): add create_file_runner factory #7857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
the
robot-svcs
Codecov Report
@@ Coverage Diff @@
## edge #7857 +/- ##
==========================================
- Coverage 93.44% 83.63% -9.81%
==========================================
Files 130 353 +223
Lines 5081 21727 +16646
==========================================
+ Hits 4748 18172 +13424
- Misses 333 3555 +3222
Continue to review full report at Codecov.
|
This was referenced Jun 1, 2021
mcous
commented
Jun 1, 2021
| @@ -51,6 +52,12 @@ def exception_handler(loop, context): | |||
| loop.set_exception_handler(None) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def decoy() -> Decoy: | |||
There was a problem hiding this comment.
Finally putting this in the top level conftest
|
|
||
|
|
||
| @pytest.fixture | ||
| def json_protocol_dict(minimal_labware_def: dict) -> dict: |
There was a problem hiding this comment.
Just moving this helpful fixture that @sanni-t added
mcous
force-pushed
the
robot-server_protocol-upload-endpoints_2
branch
from
b64bb80 to
086ae72
Compare
mcous
force-pushed
the
api_add-create-file-runner-factory_3
branch
from
48f1db4 to
069cc69
Compare
mcous
changed the base branch from
robot-server_protocol-upload-endpoints_2
to
edge
mcous
changed the base branch from
edge
to
robot-server_protocol-upload-endpoints_2
mcous
force-pushed
the
api_add-create-file-runner-factory_3
branch
from
069cc69 to
c9a98a6
Compare
sanni-t
approved these changes
Jun 3, 2021
|
Changes addressed during PR review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is 3 of 4 working towards #7816.
chore(api,robot-server): update testing dev deps chore(api,robot-server): update testing dev deps #7855Mergedrefactor(robot-server): add experimental protocol router refactor(robot-server): add experimental protocol router #7856MergedThis PR prepares for session wireup to the
JsonFileRunnerby adding a factory function to set up a JsonFileRunner.Blocked by #7856, will require sync after mergeChangelog
create_file_runnerfactory to create a file runner instance given:file_type: Python or JSON (Python and others left unimplemented)file_path: path on the filesystem to the fileengine: ProtocolEngine instanceReview requests
Risk assessment
Low, not hooked to production code