Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api,robot-server): update testing dev deps #7855

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 1, 2021

Overview

This PR is 1 of 4 that are working towards #7816.

  1. chore(api,robot-server): update testing dev deps chore(api,robot-server): update testing dev deps #7855
  2. refactor(robot-server): add experimental protocol router refactor(robot-server): add experimental protocol router #7856
  3. refactor(api): add create_file_runner factory refactor(api): add create_file_runner factory #7857
  4. refactor(robot-server): start wiring /sessions into runner and engine refactor(robot-server): start wiring /sessions into runner and engine #7858

This PR makes three changes to the api's and robot-server's dev-dep list. Pulled out into its own PR to keep imminent PR's more manageable.

Changelog

  • Swaps out pytest-watch for the much more active pytest-xdist
    • Can now do watch mode with pipenv run pytest <files> --looponfail --color=yes
  • Adds httpx to use as a test client in async FastAPI router tests
  • Upgrades decoy for a few new matchers and a typing fix to stop mypy complaining if you pass an ABC to the spec argument

Review requests

  • Test and lint dev tasks in api and robot-server still run locally on your machine
  • pytest ... --looponfail --color=yes watch mode works on your machine

Risk assessment

Only risk should be to our dev environment

@mcous mcous added the chore label Jun 1, 2021
@mcous mcous requested review from a team as code owners June 1, 2021 13:54
@mcous mcous requested a review from a team June 1, 2021 13:54
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #7855 (c4060fe) into edge (5f9c15d) will decrease coverage by 9.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #7855      +/-   ##
==========================================
- Coverage   93.51%   83.54%   -9.97%     
==========================================
  Files         124      344     +220     
  Lines        4921    21494   +16573     
==========================================
+ Hits         4602    17958   +13356     
- Misses        319     3536    +3217     
Impacted Files Coverage Δ
opentrons/calibration_storage/types.py 100.00% <0.00%> (ø)
opentrons/hardware_control/modules/update.py 28.12% <0.00%> (ø)
opentrons/hardware_control/__main__.py 0.00% <0.00%> (ø)
opentrons/commands/helpers.py 86.36% <0.00%> (ø)
opentrons/config/pipette_config.py 94.05% <0.00%> (ø)
...protocols/context/protocol_api/protocol_context.py 90.84% <0.00%> (ø)
opentrons/hardware_control/adapters.py 84.84% <0.00%> (ø)
opentrons/commands/protocol_commands.py 94.73% <0.00%> (ø)
opentrons/hardware_control/emulation/util.py 84.21% <0.00%> (ø)
opentrons/protocol_engine/protocol_engine.py 97.50% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9c15d...c4060fe. Read the comment docs.

@mcous mcous requested review from sanni-t and removed request for a team June 1, 2021 13:54
@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). and removed chore labels Jun 1, 2021
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcous mcous merged commit 1b5afd8 into edge Jun 1, 2021
@mcous mcous deleted the chore_upgrade-python-test-deps_1 branch June 1, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants