refactor(labware-creator): Break out spacing and offset sections #7798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kadee80
requested review from
a team,
shlokamin and
IanLondon
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #7798 +/- ##
=======================================
Coverage ? 83.48%
=======================================
Files ? 333
Lines ? 21243
Branches ? 0
=======================================
Hits ? 17735
Misses ? 3508
Partials ? 0 Continue to review full report at Codecov.
|
IanLondon
approved these changes
May 13, 2021
| return ( | ||
| <div className={styles.new_definition_section}> | ||
| <SectionBody label="Well Spacing"> | ||
| <> |
There was a problem hiding this comment.
is this fragment doing anything?
There was a problem hiding this comment.
yup cause SectionBody accepts children so it needs ro be a single element
| return ( | ||
| <div className={styles.new_definition_section}> | ||
| <SectionBody label="Grid Offset"> | ||
| <> |
Kadee80
force-pushed
the
lc_offsset-sections
branch
from
adb0c93 to
60d658e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes #7707 by breaking out the spacing and offset sections.
Changelog
Review requests
PS - I had to write a weirdo helper function to match text with
<strong>tags within it. Please sanity check!Risk assessment
Low but double check LC works as expected