Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LC Cleanup: Break out each form Section into separate components #7707

Closed
11 tasks done
Kadee80 opened this issue Apr 23, 2021 · 0 comments · Fixed by #7798
Closed
11 tasks done

LC Cleanup: Break out each form Section into separate components #7707

Kadee80 opened this issue Apr 23, 2021 · 0 comments · Fixed by #7798
Assignees
@shlokamin
Labels
labware creator

Comments

@Kadee80
Copy link
Contributor

Kadee80 commented Apr 23, 2021 •
edited
Loading

Overview

Use useFormikContext to pass groups of <Section>s the props they need without drilling. This will let us parallelize work without merge conflicts for the UI work.

Sections to break out

  • Create new definition
  • Upload existing labware
  • Regularity
  • Footprint
  • Height
  • Grid
  • Volume
  • Well shape and size
  • Well bottom and depth
  • Well spacing
  • Grid offset

Note - as we break these out in their own components we should revisit ternary description text as either constants or i18n

Includes test coverage for each component
@shlokamin shlokamin self-assigned this Apr 27, 2021
shlokamin added a commit that referenced this issue Apr 28, 2021
@shlokamin
refactor(labware-creator): split apart sections into separate components
12ce1d4 
#7707
@shlokamin shlokamin mentioned this issue Apr 28, 2021
Merged
shlokamin added a commit that referenced this issue Apr 28, 2021
@shlokamin
refactor(labware-creator): split apart sections into separate compone…
077aa25 
…nts (#7735)

#7707
shlokamin added a commit that referenced this issue Apr 29, 2021
@shlokamin
refactor(labware-creator): break out footprint section into its own c…
cbfb917 
…omponent

#7707
shlokamin added a commit that referenced this issue Apr 30, 2021
@shlokamin
refactor(labware-creator): break apart footprint section (#7737)
e8f2ae9 
* test(labware-creator): add missing tests to sections

* refactor(labware-creator): break out footprint section into its own component

#7707
Kadee80 added a commit that referenced this issue May 3, 2021
@Kadee80
refactor(labware-creator): Break out height section and add tests
ac1c004 
adresses #7707
@Kadee80 Kadee80 mentioned this issue May 3, 2021
Merged
2 tasks
Kadee80 added a commit that referenced this issue May 4, 2021
@Kadee80
refactor(labware-creator): Break out grid and volume sections
1a423dc 
addresses #7707
@Kadee80 Kadee80 mentioned this issue May 4, 2021
Merged
3 tasks
Kadee80 added a commit that referenced this issue May 4, 2021
@Kadee80
refactor(labware-creator): Break out grid and volume sections
8d69450 
addresses #7707
Kadee80 added a commit that referenced this issue May 4, 2021
@Kadee80
refactor(labware-creator): Break out grid and volume sections
fbb45a0 
addresses #7707
shlokamin added a commit that referenced this issue May 5, 2021
@shlokamin
feat(labware-creator): hide section components when all fields are hi…
94d36b8 
…dden

#7707
Kadee80 added a commit that referenced this issue May 11, 2021
@Kadee80
refactor(labware-creator): Break out well shape and depth sections
9dfccc6 
addresses #7707
@Kadee80 Kadee80 mentioned this issue May 11, 2021
Merged
2 tasks
Kadee80 added a commit that referenced this issue May 12, 2021
@Kadee80
refactor(labware-creator): Break out spacing and offset sections
d32c5c4 
closes #7707
Kadee80 added a commit that referenced this issue May 12, 2021
@Kadee80
refactor(labware-creator): Break out spacing and offset sections
b8c7842 
closes #7707
@Kadee80 Kadee80 mentioned this issue May 12, 2021
Merged
2 tasks
Kadee80 added a commit that referenced this issue May 19, 2021
@Kadee80
refactor(labware-creator): Break out spacing and offset sections
e29a67e 
closes #7707
Kadee80 added a commit that referenced this issue May 19, 2021
@Kadee80
refactor(labware-creator): Break out spacing and offset sections (#7798)
d1fbefc 
closes #7707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlokamin shlokamin

Labels
labware creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(labware-creator): Break out spacing and offset sections Opentrons/opentrons
2 participants
@Kadee80 @shlokamin