Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): represent Location correctly in log #7565

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

amitlissack
Copy link
Contributor

Overview

Location used to be a namedtuple instead of a class. There's no repr function so Location objects are meaningless in run logging.

closes #7564

Changelog

Implement repr for Location class with tests

Review requests

Risk assessment

Low

…r__ function so Location objects are meaningless in run logging.
@amitlissack amitlissack added api Affects the `api` project fix PR fixes a bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 30, 2021
@amitlissack amitlissack requested review from a team and mcous and removed request for a team March 30, 2021 18:05
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (edge@e3222bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #7565   +/-   ##
=======================================
  Coverage        ?   82.17%           
=======================================
  Files           ?      311           
  Lines           ?    20723           
  Branches        ?        0           
=======================================
  Hits            ?    17030           
  Misses          ?     3693           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3222bc...859d78d. Read the comment docs.

@amitlissack amitlissack marked this pull request as ready for review March 30, 2021 18:15
@amitlissack amitlissack requested a review from a team as a code owner March 30, 2021 18:15
@amitlissack amitlissack merged commit be091a3 into edge Mar 30, 2021
@amitlissack amitlissack deleted the api-bug_7594-Location branch March 30, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project fix PR fixes a bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: API log files no longer include the slot number where a piece of labware is located
2 participants