Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: API log files no longer include the slot number where a piece of labware is located #7564

Closed
ethanfjones-zz opened this issue Mar 30, 2021 · 0 comments · Fixed by #7565
Assignees
Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Milestone

Comments

@ethanfjones-zz
Copy link
Contributor

Overview

API log file commands now include alphanumeric characters instead of the numbered slot where a piece of labware is located.

Steps to reproduce

  1. Run a protocol with an API version of 2.9 on an OT-2 with a software version of 4.1.1 or above
  2. Download and review the API log files

Current behavior

An aspirate step in the API log files now looks like:

InstrumentContext.aspirate: {'volume': 100, 'location': <opentrons.types.Location object at 0x70f62dd0>, 'rate': 1.0}

Expected behavior

An aspirate step in the API log files should look like:

InstrumentContext.aspirate: {'volume': 100, 'location': Location(point=Point(x=63.88, y=42.74, z=5.550000000000001), labware=A1 of rez on 1), 'rate': 1.0}

@ethanfjones-zz ethanfjones-zz added bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 30, 2021
@amitlissack amitlissack self-assigned this Mar 30, 2021
@amitlissack amitlissack added this to the CPX Sprint 29 milestone Mar 30, 2021
amitlissack pushed a commit that referenced this issue Mar 30, 2021
Location used to be a namedtuple instead of a class. There's no __repr__ function so Location objects are meaningless in run logging.

closes #7564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants