fix(api): Sleeps do not happen in thermocycler and tempdeck when simulating.

[amitlissack]

Overview

An issue discovered during testing of fast simulation: asyncio.sleep calls in Thermocycler and Tempdeck caused needless delays in simulation.

This is a simple solution that eliminates the simulation issue. More broadly, we should strive to not use asyncio.sleep or time.sleep in our codebase. Sleep intervals are almost always estimates that can lead to unnecessary delays.

closes #7506

Changelog

• skip sleep calls when simulating

Review requests

Risk assessment

None

[codecov]

Codecov Report

Merging #7515 (9a8489e) into edge (78869dc) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             edge    #7515      +/-   ##
==========================================
- Coverage   82.21%   82.17%   -0.05%     
==========================================
  Files         310      310              
  Lines       20646    20654       +8     
==========================================
- Hits        16975    16972       -3     
- Misses       3671     3682      +11     

Impacted Files	Coverage Δ
opentrons/hardware_control/modules/tempdeck.py	82.89% <0.00%> (-5.11%)	⬇️
opentrons/hardware_control/modules/thermocycler.py	91.46% <0.00%> (-2.85%)	⬇️
opentrons/drivers/thermocycler/driver.py	73.80% <0.00%> (-0.26%)	⬇️
opentrons/__init__.py	53.68% <0.00%> (+3.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78869dc...9a8489e. Read the comment docs.

[Laura-Danielle]

Looks good to me, do we want to get this into 4.2 @nusrat813? If so, we should point this to the release branch.

[amitlissack]

Looks good to me, do we want to get this into 4.2 @nusrat813? If so, we should point this to the release branch.

@nusrat813 and I agreed that it is not worth delaying release for this.