Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(api): Thermocycler sleeps during simulation #7506

Closed
3 tasks
amitlissack opened this issue Mar 17, 2021 · 0 comments · Fixed by #7515
Closed
3 tasks

bug(api): Thermocycler sleeps during simulation #7506

amitlissack opened this issue Mar 17, 2021 · 0 comments · Fixed by #7515
Assignees
@amitlissack
Labels
api Affects the `api` project bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@amitlissack
Copy link
Contributor

Overview

opentrons.hardware_control.modules.thermocycler.Thermocycler has a number of asyncio.sleep statements. These happen even during simulation causing needless delays in upload.

Acceptance Criteria

asyncio.sleep should not be called when simulating in:

  • wait_for_lid_temp
  • wait_for_temp
  • wait_for_hold
@amitlissack amitlissack added api Affects the `api` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). bug labels Mar 17, 2021
@amitlissack amitlissack changed the title fix(api): Thermocycler sleeps during simulation bug(api): Thermocycler sleeps during simulation Mar 17, 2021
@amitlissack amitlissack self-assigned this Mar 18, 2021
@amitlissack amitlissack mentioned this issue Mar 18, 2021
Merged
amitlissack pushed a commit that referenced this issue Mar 19, 2021
fix(api): Sleeps do not happen in thermocycler and tempdeck when simu…
8ef61c0 
…lating.

closes #7506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitlissack amitlissack

Labels
api Affects the `api` project bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): Sleeps do not happen in thermocycler and tempdeck when simulating. Opentrons/opentrons
1 participant
@amitlissack