Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): bump pyserial dependency in setup.py #7250

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jan 23, 2021

Overview

The pyserial dependency was bumped to 3.5 (in the Pipfile and Builroot) in the v4.1.0 release, but setup.py still specifies 3.4, which means the package thinks it needs 3.4.

This PR fixes setup.py so the opentrons package knows what version of pyserial it actually wants.

Changelog

  • fix(api): bump pyserial dependency in setup.py

Review requests

Pretty self explanatory

Risk assessment

Bugfix

@mcous mcous requested a review from a team as a code owner January 23, 2021 02:10
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #7250 (e6cfd3d) into chore_release-4.1.1 (a50f900) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-4.1.1    #7250      +/-   ##
=======================================================
+ Coverage                79.11%   79.16%   +0.04%     
=======================================================
  Files                      289      265      -24     
  Lines                    20218    19161    -1057     
=======================================================
- Hits                     15995    15168     -827     
+ Misses                    4223     3993     -230     
Impacted Files Coverage Δ
opentrons/protocol_engine/state/motion.py 100.00% <0.00%> (ø)
opentrons/protocol_engine/commands/aspirate.py 100.00% <0.00%> (ø)
opentrons/protocol_engine/execution/pipetting.py 100.00% <0.00%> (ø)
...trons/protocol_engine/commands/pipetting_common.py 100.00% <0.00%> (ø)
...otify-server/notify_server/models/sample_events.py
update-server/otupdate/buildroot/__init__.py
update-server/otupdate/buildroot/update.py
.../notify_server/models/hardware_event/door_state.py
...erver/notify_server/models/hardware_event/names.py
update-server/otupdate/buildroot/file_actions.py
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50f900...e6cfd3d. Read the comment docs.

@mcous mcous added bug fix PR fixes a bug ready for review api Affects the `api` project labels Jan 23, 2021
@sfoster1 sfoster1 changed the base branch from edge to chore_release-4.1.1 January 25, 2021 14:12
@sfoster1 sfoster1 requested review from a team as code owners January 25, 2021 14:12
@sfoster1 sfoster1 requested review from a team, SyntaxColoring, Kadee80 and shlokamin and removed request for a team January 25, 2021 14:12
@mcous mcous force-pushed the api_fix-pyserial-dep branch from e918576 to e6cfd3d Compare January 25, 2021 14:15
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches buildroot

@mcous mcous merged commit 052b783 into chore_release-4.1.1 Jan 25, 2021
@nusrat813 nusrat813 self-requested a review January 25, 2021 21:51
@mcous mcous deleted the api_fix-pyserial-dep branch June 1, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project bug fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants