-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(robot-server): Robot server command responses #7170
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #7170 +/- ##
==========================================
+ Coverage 78.71% 87.38% +8.67%
==========================================
Files 264 99 -165
Lines 18953 4551 -14402
==========================================
- Hits 14918 3977 -10941
+ Misses 4035 574 -3461
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, love generics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited for this!
Overview
Refactor session command models to eliminate dreaded
Union
problems in requests and responses.closes #6519
Changelog
SessionCommandRequest
is a generic that accepts the command type, request data, and response data.SessionCommandResponse
is derived from SessionCommandRequestSessionCommandRequest.make_response
creates aSessionCommandResponse
Review requests
Is this clear? Do the comments help?
Risk assessment
Low. Unit and tavern tests beat up on this code pretty well.