Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(app): add unit tests for robot InformationCard #6957

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Nov 10, 2020

Overview

This PR is part of #5174, and adds unit tests to the robot settings page's InformationCard. These tests (along with health endpoint integration tests) should be able to replace manual QA test TS03-C004.

Changelog

  • test(app): add unit tests for robot InformationCard

Review requests

  • Do the tests look like they cover the test case accurately?

Risk assessment

N/A - test only PR

@mcous mcous added app Affects the `app` project ready for review robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). qa QA input / review required labels Nov 10, 2020
@mcous mcous requested a review from a team as a code owner November 10, 2020 18:23
@mcous mcous requested review from Kadee80 and nusrat813 and removed request for a team November 10, 2020 18:23
Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcous mcous merged commit 91f4442 into chore_release-4.0.0-beta.0 Nov 11, 2020
@mcous mcous deleted the app_refactor-robot-update-for-tests branch November 11, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project qa QA input / review required robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants