Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: increase test coverage of robot update UI #5174

Closed
1 task
mcous opened this issue Mar 6, 2020 · 3 comments
Closed
1 task

Test: increase test coverage of robot update UI #5174

mcous opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels
app Affects the `app` project bug chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). WIP

Comments

@mcous
Copy link
Contributor

mcous commented Mar 6, 2020

overview

A large chunk of our manual testing burden is dedicated to testing a large test matrix trying to make sure the UI behaves (e.g. when are release notes displayed?) in various different cases of app / robot version mismatches.

This UI testing is less important than ensuring the updates are successfully applied, so it's a good candidate for shifting the burden over to unit tests so the manual testing can focus on actual critical functionality.

acceptance criteria

As much as arbitrary coverage thresholds aren't necessarily a recipe for success, we clearly need something here. Let's call it:

  • Coverage of robot-update related app and app-shell code is >= 80%

implementation details

These files / directories contain most, if not all of the app-side robot update functionality.

Those coverage numbers are pretty awful! Let's get this fixed up

@mcous mcous added app Affects the `app` project chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 6, 2020
@mcous mcous modified the milestone: CPX Sprint 6 Mar 31, 2020
@mcous mcous added this to the CPX Sprint 17 milestone Sep 1, 2020
@mcous mcous modified the milestones: CPX Sprint 17, CPX Sprint 19 Sep 24, 2020
@mcous
Copy link
Contributor Author

mcous commented Oct 14, 2020

TODO: break this ticket up into smaller chunks. Parts of this have been addressed in various feature buildouts (e.g. disable app update notifications)

@mcous
Copy link
Contributor Author

mcous commented Nov 19, 2020

Once 4.0 is released, re-evaluate the coverage numbers and/or the need for this ticket (in favor of smaller, more specific tickets)

@mattwelch mattwelch added the bug label Mar 4, 2021
@mcous
Copy link
Contributor Author

mcous commented Jun 3, 2021

Done enough to need new tickets now that app e2e testing is moving forward

@mcous mcous closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). WIP
Projects
None yet
Development

No branches or pull requests

3 participants