refactor(app): ensure proper API cal data is associated to protocol labware #6280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR follows up on an #6100 and #6246. A given labware used in a protocol should be associated to a given entry in the labware calibrations results if the labware's:
The implementation I wrote in #6100 was buggy, and #6246 noted that it resulted in incorrect quantities being displayed in the table. However, it it turns out 6100 was buggy for both quantity linking and calibration data linking. If a labware does not have a module parent, it could get linked (in UI) to module-based calibration data if the module-based calibration entry was earlier in the response array.
This PR adds a test and fix for this case.
changelog
review requests
risk assessment
Low. Unit test coverage was already high for this logic, and bug+fix was TDD'd.