Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(app): remove commented out tests #6169

Merged
merged 2 commits into from
Aug 4, 2020
Merged

test(app): remove commented out tests #6169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b0dbf
test(app): remove commented out tests
shlokamin Jul 17, 2020
d85c221
add todos
shlokamin Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 5 additions & 45 deletions app/src/components/ModuleItem/__tests__/ModuleUpdate.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,51 +26,6 @@ describe('ModuleUpdate', () => {
jest.resetAllMocks()
})

// TODO(mc, 2020-03-16): these shallow snapshots don't test anything
// remove commented out tests when actual tests have been written
// it('component renders', () => {
// const treeAvailableCanControl = shallow(
// <Provider store={store}>
// <ModuleUpdate
// controlDisabledReason={null}
// moduleId="FAKEMODULE1234"
// hasAvailableUpdate={true}
// />
// </Provider>,
// )
// const treeAvailableNoControl = shallow(
// <Provider store={store}>
// <ModuleUpdate
// controlDisabledReason={"Can't touch this"}
// moduleId="FAKEMODULE1234"
// hasAvailableUpdate={true}
// />
// </Provider>
// )
// const treeNotAvailableCanControl = shallow(
// <Provider store={store}>
// <ModuleUpdate
// controlDisabledReason={null}
// moduleId="FAKEMODULE1234"
// hasAvailableUpdate={false}
// />
// </Provider>
// )
// const treeNotAvailableNoControl = shallow(
// <Provider store={store}>
// <ModuleUpdate
// controlDisabledReason={"Can't touch this"}
// moduleId="FAKEMODULE1234"
// hasAvailableUpdate={false}
// />
// </Provider>
// )
// expect(treeAvailableCanControl).toMatchSnapshot()
// expect(treeNotAvailableCanControl).toMatchSnapshot()
// expect(treeAvailableNoControl).toMatchSnapshot()
// expect(treeNotAvailableNoControl).toMatchSnapshot()
// })

it('displays a Warning for invalid files', () => {
const SPECS = [
{
Expand Down Expand Up @@ -110,4 +65,9 @@ describe('ModuleUpdate', () => {
}
)
})

it.todo('is available and can control')
it.todo('is available and cannot control')
it.todo('is not available and can control')
it.todo('is not available and cannot control')
})