Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(app): remove commented out tests #6169

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Conversation

shlokamin
Copy link
Member

Overview

Deleting these commented out tests to remove the linter warning. I didn't actually write new tests to cover what these commented snapshots were supposed to be covering, but maybe we can create a ticket or something to do so.

Review requests

NA

Risk assessment

Low

remove commented out tests to get rid of linter warning
@shlokamin shlokamin requested review from mcous and a team July 17, 2020 15:38
@shlokamin shlokamin requested a review from a team as a code owner July 17, 2020 15:38
@shlokamin shlokamin requested review from amitlissack and removed request for a team July 17, 2020 15:38
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@shlokamin shlokamin merged commit 1bdc118 into edge Aug 4, 2020
@shlokamin shlokamin deleted the app_remove-commented-tests branch August 4, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants