Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): Add module prefix to labware #5205

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented Mar 11, 2020

overview

closes #5119. Adds module prefix to labware on top of modules for transfer and mix form labware dropdowns.

changelog

  • feat(protocol-designer): Add module prefix to labware

review requests

make a protocol with both modules
add labware on top of those modules
add some other labware
create a transfer step

  • aspirate and dispense labware dropdowns show MAG or TEMP prefix before the labware name or nickname
    create a mix step
  • source labware dropdowns show MAG or TEMP prefix before the labware name or nickname

@Kadee80 Kadee80 added ready for review protocol designer Affects the `protocol-designer` project labels Mar 11, 2020
Copy link
Contributor

@jen-fong jen-fong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add some tests for this new feature?

reduce(
labwareEntities,
(acc: Options, l: LabwareEntity, labwareId: string): Options => {
const module = getModuleUnderLabware(initialDeckSetup, labwareId)
console.log(module)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 leftover console log

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5205 into edge will increase coverage by 0.43%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##            edge    #5205      +/-   ##
=========================================
+ Coverage   60.3%   60.73%   +0.43%     
=========================================
  Files       1025     1025              
  Lines      29056    30022     +966     
=========================================
+ Hits       17522    18234     +712     
- Misses     11534    11788     +254
Impacted Files Coverage Δ
protocol-designer/src/ui/modules/utils.js 11.11% <0%> (-1.39%) ⬇️
protocol-designer/src/ui/labware/selectors.js 41.66% <0%> (-13.89%) ⬇️
opentrons/hardware_control/types.py 98% <0%> (-2%) ⬇️
opentrons/hardware_control/execution_manager.py 94.44% <0%> (-1.21%) ⬇️
...signer/src/components/LiquidPlacementForm/index.js 0% <0%> (ø) ⬆️
protocol-designer/src/components/FilePage.js 0% <0%> (ø) ⬆️
...igner/src/components/LiquidsPage/LiquidEditForm.js 0% <0%> (ø) ⬆️
...components/AppSettings/AddManualIp/ManualIpForm.js 0% <0%> (ø) ⬆️
...ibrary/src/labware-creator/components/TextField.js 0% <0%> (ø) ⬆️
...src/components/ConfigurePipette/ConfigFormGroup.js 0% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981d941...717821e. Read the comment docs.

@IanLondon IanLondon requested a review from jen-fong March 13, 2020 20:23
@IanLondon IanLondon merged commit 1f979dd into edge Mar 13, 2020
@IanLondon IanLondon deleted the pd_prefix-module-labware branch March 13, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules in PD: all labware selection dropdowns should use module name if relevant
3 participants