-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): Add module prefix to labware #5205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add some tests for this new feature?
reduce( | ||
labwareEntities, | ||
(acc: Options, l: LabwareEntity, labwareId: string): Options => { | ||
const module = getModuleUnderLabware(initialDeckSetup, labwareId) | ||
console.log(module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 leftover console log
Codecov Report
@@ Coverage Diff @@
## edge #5205 +/- ##
=========================================
+ Coverage 60.3% 60.73% +0.43%
=========================================
Files 1025 1025
Lines 29056 30022 +966
=========================================
+ Hits 17522 18234 +712
- Misses 11534 11788 +254
Continue to review full report at Codecov.
|
overview
closes #5119. Adds module prefix to labware on top of modules for transfer and mix form labware dropdowns.
changelog
review requests
make a protocol with both modules
add labware on top of those modules
add some other labware
create a transfer step
create a mix step