Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update top level README and remove unused legacy files #4717

Merged
merged 11 commits into from
Jan 15, 2020

Conversation

b-cooper
Copy link
Contributor

Changelog

  • remove old architecture_and_planning writeup that is no longer accurate and otherwise covered by the newer CONTRIBUTING.md
  • remove monorepo copy of audio speaker test, as it is built into BR
  • remove unused .dockerignore
  • update top level README.md copy for accuracy
  • add PD to top level README.md

@b-cooper b-cooper requested a review from a team January 10, 2020 21:59
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #4717 into edge will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4717      +/-   ##
==========================================
+ Coverage   58.05%   58.13%   +0.08%     
==========================================
  Files         955      958       +3     
  Lines       26254    26831     +577     
==========================================
+ Hits        15242    15599     +357     
- Misses      11012    11232     +220
Impacted Files Coverage Δ
opentrons/server/http.py 92.53% <0%> (-0.45%) ⬇️
...l-designer/src/top-selectors/tip-contents/index.js 0% <0%> (ø) ⬆️
...tocol-designer/src/components/steplist/StepItem.js 0% <0%> (ø) ⬆️
.../RobotSettings/UpdateBuildroot/SyncRobotMessage.js 0% <0%> (ø) ⬆️
protocol-designer/src/top-selectors/substeps.js 0% <0%> (ø) ⬆️
...c/components/StepEditForm/forms/TemperatureForm.js 0% <0%> (ø) ⬆️
...col-designer/src/components/DeckSetup/DeckSetup.js 0% <0%> (ø) ⬆️
...col-designer/src/components/DeckSetup/ModuleTag.js 0% <0%> (ø) ⬆️
...tocol-designer/src/top-selectors/timelineFrames.js 15.78% <0%> (ø)
...esigner/src/components/steplist/MagnetStepItems.js 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14d887...f5475fb. Read the comment docs.

Copy link
Contributor

@btmorr btmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for keeping this cleaned up

@IanLondon
Copy link
Contributor

🚢 🌊 🎵

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've got a couple tiny edit requests if we want them

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@b-cooper b-cooper merged commit 3a57ad4 into edge Jan 15, 2020
@b-cooper b-cooper deleted the house-keeping branch February 6, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants