Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: Provide up-to-date architecture documentation #4375

Closed
theosanderson opened this issue Nov 5, 2019 · 4 comments
Closed

other: Provide up-to-date architecture documentation #4375

theosanderson opened this issue Nov 5, 2019 · 4 comments
Assignees
Labels
docs robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@theosanderson
Copy link
Contributor

overview

Specifically, if I understand correctly, https://github.com/Opentrons/opentrons/blob/edge/architecture-and-planning/backend-architecture.md is out of date in referring to ResinOS (if I am correct in understanding that this has now been migrated away from).

More generally, as a tech-savvy user it has been quite difficult for me to get a sense of how the OT2 now fits together - I am on top of the API, and I realise that this is the most important thing, but it would be great for me to be able to understand exactly what is on the Raspberry Pi in my OT2 and where this is defined in the codebase. It took me a while to find the buildroot repo, which if I am correct defines a significant amount of this?

[I know things are in flux at the moment, and this is all very much intended as an observation rather than a complaint! I also realise that things are set up for devs and not me, and that's fair enough!]

@theosanderson
Copy link
Contributor Author

OK I finally found this important directory: https://github.com/Opentrons/buildroot/tree/opentrons-develop/board/opentrons/ot2 I think it would be cool if that was highlighted on the buildroot main README.md, and if the buildroot repo was described in the opentrons README.md.

@bndo bndo added the docs label Nov 7, 2019
@sfoster1
Copy link
Member

sfoster1 commented Nov 7, 2019

You're totally right - we've done a bad job keeping that file up to date, and in general documenting the software architecture of the robot. We'll work to fix that and tag the PRs to this ticket.

@mcous mcous added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Jan 17, 2020
@SyntaxColoring
Copy link
Contributor

The specific file that @theosanderson mentioned was deleted as part of #4717.

I'm leaving this ticket open because I don't think that materially changes the issue. Whereas we had out-of-date architecture documentation before, we just don't have any architecture documentation now. 😅

@SyntaxColoring SyntaxColoring changed the title other: Architecture documentation is out of date other: Provide up-to-date architecture documentation Jun 4, 2020
sfoster1 pushed a commit that referenced this issue Aug 5, 2020
This is a quick attempt to describe things that might as an outsider have helped me to understand how my OT2 works. The text is clumsy in many ways and I'm sure not comprehensive, but I thought I'd submit the PR on the basis that something is better than nothing, and as a starting point for improvement. I won't be at all offended if you don't agree and want to hold off on this until you have time to sit down and do it properly.

I think things can be quite opaque e.g. "what does the robot server do?" (#6164 (comment)) and that signposting users to the code that is more likely to be relevant to them (API, then buildroot and robot server) as opposed to not (protocol designer, labware designer, etc.) could be helpful.

Intended to fix (in part) #4375.

Co-authored-by: Max Marrone <[email protected]>
Co-authored-by: Theo <[email protected]>
@SyntaxColoring SyntaxColoring self-assigned this Jun 3, 2021
@SyntaxColoring
Copy link
Contributor

I'm closing this because I think it's been addressed by #6245. I've just reviewed OT2_ARCHITECTURE.md and confirmed it's still correct.

Of course, I don't think this is the end of the story for architecture and platform documentation. But now that OT2_ARCHITECTURE.md exists, we can work on it incrementally as more specific gaps are identified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

No branches or pull requests

5 participants