Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): add format check to CI lint job #4059

Merged
merged 2 commits into from
Sep 17, 2019
Merged

ci(travis): add format check to CI lint job #4059

merged 2 commits into from
Sep 17, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 16, 2019

overview

I've been noticing various changes getting merged into edge without running make format, which results in future PRs where someone does run make format getting poluted

This PR adds a format check step to CI to ensure unformatted files do not get merged into edge

changelog

  • ci(travis): add format check to CI lint job
  • style: run make format with upgraded prettier

review requests

  • CI + dep version changes in first commit look good
  • Automated format changes in second commit look good
    • Since prettier was upgraded, this is a combination of changes due to the prettier upgrade (any .js file) and formatting changes that were missed in edge (any .json file)

@mcous mcous requested review from a team September 16, 2019 18:20
@mcous mcous changed the title Ci format check ci(travis): add format check to CI lint job Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #4059 into edge will increase coverage by 0.21%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4059      +/-   ##
==========================================
+ Coverage   57.29%   57.51%   +0.21%     
==========================================
  Files         850      850              
  Lines       23916    24055     +139     
==========================================
+ Hits        13703    13835     +132     
- Misses      10213    10220       +7
Impacted Files Coverage Δ
components/src/deck/LabwareRender.js 0% <ø> (ø) ⬆️
...p-generation/getNextRobotStateAndWarnings/index.js 33.33% <ø> (ø) ⬆️
shared-data/js/helpers/getWellTotalVolume.js 16.66% <ø> (ø) ⬆️
shared-data/js/helpers/getWellNamePerMultiTip.js 100% <ø> (ø) ⬆️
...mponents/ModuleLiveStatusCards/ThermocyclerCard.js 0% <ø> (ø) ⬆️
protocol-designer/src/step-forms/utils.js 33.33% <ø> (ø) ⬆️
...ep-generation/commandCreators/compound/transfer.js 100% <ø> (ø) ⬆️
...tocol-designer/src/file-data/selectors/commands.js 21.87% <ø> (ø) ⬆️
protocol-designer/src/steplist/generateSubsteps.js 0% <ø> (ø) ⬆️
...l-designer/src/components/labware/SingleLabware.js 0% <ø> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4ace6...5a11a18. Read the comment docs.

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants