Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Fix changelog instructions sublist #4074

Merged
merged 1 commit into from
Sep 17, 2019
Merged

docs(contributing): Fix changelog instructions sublist #4074

merged 1 commit into from
Sep 17, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 17, 2019 •
edited
Loading

overview

Tiny PR to fix a sublist in CHANGELOG.md

@mcous mcous requested a review from a team September 17, 2019 19:29
b-cooper
b-cooper approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@mcous mcous force-pushed the style_fix-md-format branch from 26ae7f2 to eba0102 Compare September 17, 2019 19:36
@mcous mcous changed the title style(docs): format CONTRIBUTING.md docs(contributing): Fix changelog instructions sublist Sep 17, 2019
@mcous mcous merged commit c377d6a into edge Sep 17, 2019
@mcous mcous deleted the style_fix-md-format branch September 17, 2019 20:28
@codecov
Copy link

codecov bot commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #4074 into edge will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            edge    #4074      +/-   ##
=========================================
+ Coverage   57.2%   57.27%   +0.06%     
=========================================
  Files        851      850       -1     
  Lines      23972    23940      -32     
=========================================
- Hits       13714    13711       -3     
+ Misses     10258    10229      -29
Impacted Files Coverage Δ
...p/src/components/ChangePipette/PipetteSelection.js 0% <0%> (ø) ⬆️
components/src/instrument/InfoItem.js
components/src/instrument/InstrumentGroup.js
components/src/instrument/InstrumentInfo.js
components/src/instrument/PipetteSelect.js
components/src/instrument/InstrumentDiagram.js
components/src/instrument-diagram/InfoItem.js 100% <0%> (ø)
...mponents/src/instrument-diagram/InstrumentGroup.js 100% <0%> (ø)
...omponents/src/instrument-diagram/InstrumentInfo.js 100% <0%> (ø)
...onents/src/instrument-diagram/InstrumentDiagram.js 71.42% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f0713...eba0102. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-cooper b-cooper b-cooper approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcous @b-cooper