fix(protocol-designer): fix recurring deleted labware bug #2299
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make labware access by id always maybe typed (?Labware) so flow ensures safe access
IanLondon
added
ready for review
fix
howisthisnamenottakenyet
approved these changes
Sep 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Fix our recurring deleting labware bug #1406 #1614 ...once and for all?
The problem is the worst when you delete a labware that one or more steps are using, in edge it whitescreens.
At least this will have Flow ensure that accessing labware by id will be safe, and not whitescreen due to
TypeError: ___ is undefined.changelog
review requests
The UI won't whitescreen with this PR, but it'll be a little weird. #2161 will address the UI issues left in place by this PR.