Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD Bug: deleting labware -> wonky UI #2161

Closed
2 of 3 tasks
IanLondon opened this issue Aug 29, 2018 · 2 comments
Closed
2 of 3 tasks

PD Bug: deleting labware -> wonky UI #2161

IanLondon opened this issue Aug 29, 2018 · 2 comments
Assignees
Labels
blocked Ticket or PR is blocked by other work bug protocol designer Affects the `protocol-designer` project

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Aug 29, 2018

Deleting a labware that is used in a step is an ugly experience

Steps to reproduce

  1. Create some labware, tips, and a transfer step (for example), and save the step
  2. Go to Deck Setup and delete the labware
  • Labware dropdown isn't blank (whatever labware is on the top of the dropdown looks like it's selected)
  • Well selection isn't disabled, clicking it shows the blank "Custom labware" plate

Expected behavior

@IanLondon IanLondon added bug protocol designer Affects the `protocol-designer` project labels Aug 29, 2018
@IanLondon IanLondon added this to the Protocol Designer: Bugs milestone Aug 29, 2018
@IanLondon IanLondon changed the title PD Bug: deleting labware -> whitescreen PD Bug: deleting labware -> wonky UI Sep 18, 2018
@IanLondon IanLondon self-assigned this Sep 20, 2018
@IanLondon IanLondon added the blocked Ticket or PR is blocked by other work label Sep 20, 2018
@IanLondon
Copy link
Contributor Author

PR #2341 gets us 50% there, but I'm calling this ticket blocked because the part where selected wells gets cleared out would mean adding an independent path to updating forms. Discussed with @b-cooper and we agree that we should put this off at least until we do "user can save the form any time" behavior, and/or until we at least have a plan for the more flexible step form.

@IanLondon
Copy link
Contributor Author

Splitting the punted part off to #2361 (clear well selection), so outside of that part, this ticket is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket or PR is blocked by other work bug protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

No branches or pull requests

1 participant