Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add persistent unique user ID to intercom data #2004

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Aug 3, 2018

overview

This PR updates the intercom configuration to attach a unique user ID (generated on first open of the app) that is stored on the filesystem to persist between app openings and re-installs. This should allow users to keep their conversations going.

It also lays a little bit of groundwork for users to be able to input their name and email for support purposes.

Closes #1999

changelog

  • feat(app): Add persistent unique user ID to intercom data

review requests

I separated support from analytics to make sure we don't leak data between the too and keep our modules (the code kind) more focused.

  • App still initializes MixPanel and sends analytics events
    • Remember to set OT_APP_MIXPANEL_ID
  • New conversation shows up with unique user_id and generic "App User" name in intercom
    • Remember to set OT_APP_INTERCOM_ID
    • Ask me for a testing environment ID to avoid confusing our support folks

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Aug 3, 2018
@mcous mcous changed the title feat(app): Add persistant unique user ID to intercom data feat(app): Add persistent unique user ID to intercom data Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #2004 into edge will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #2004      +/-   ##
==========================================
- Coverage   32.16%   31.87%   -0.29%     
==========================================
  Files         429      430       +1     
  Lines        6867     6948      +81     
==========================================
+ Hits         2209     2215       +6     
- Misses       4658     4733      +75
Impacted Files Coverage Δ
app/src/config/index.js 45.45% <ø> (ø) ⬆️
app-shell/lib/config.js 40% <ø> (ø) ⬆️
app/src/analytics/index.js 0% <ø> (ø) ⬆️
app/src/support.js 0% <0%> (ø)
app/src/index.js 0% <0%> (ø) ⬆️
...er/src/components/StepEditForm/TransferLikeForm.js 0% <0%> (ø) ⬆️
...designer/src/components/StepEditForm/formFields.js 0% <0%> (ø) ⬆️
protocol-designer/src/steplist/formProcessing.js 3.67% <0%> (+0.14%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938a3fa...ed032f3. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎤 🌐

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏯

@mcous mcous merged commit 0a47d64 into edge Aug 6, 2018
@mcous mcous deleted the app_intercom-user-id branch August 6, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants