fix(components): Make preventDefault call in HandleKeypress opt-in #1768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Previously,
<HandleKeypress>
would callevent.preventDefault
if the keypress event matched one of its handlers. This is necessary functionality for its current use in the app (to prevent jog step size radio button shenanigans on arrow key presses), but should've been configurable. This PR makes the prevent default functionality opt-in.Closes #1764
changelog
review requests
q
,w
, ande
into code blocks)