Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): Make preventDefault call in HandleKeypress opt-in #1768

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 28, 2018

overview

Previously, <HandleKeypress> would call event.preventDefault if the keypress event matched one of its handlers. This is necessary functionality for its current use in the app (to prevent jog step size radio button shenanigans on arrow key presses), but should've been configurable. This PR makes the prevent default functionality opt-in.

Closes #1764

changelog

  • fix(components): Make preventDefault call in HandleKeypress opt-in

review requests

@mcous mcous added fix PR fixes a bug components Affects the `components` project ready for review labels Jun 28, 2018
@mcous mcous requested review from Kadee80, b-cooper and IanLondon June 28, 2018 12:46
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌃 🌆

@mcous mcous merged commit 9e64fb2 into edge Jun 28, 2018
@mcous mcous deleted the cl_handle-keypress-allow-default branch June 28, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Affects the `components` project fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HandleKeypress in Styleguide doesn't let you type q/w/e keys in code blocks
2 participants