Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandleKeypress in Styleguide doesn't let you type q/w/e keys in code blocks #1764

Closed
IanLondon opened this issue Jun 27, 2018 · 1 comment · Fixed by #1768 or #1845
Closed

HandleKeypress in Styleguide doesn't let you type q/w/e keys in code blocks #1764

IanLondon opened this issue Jun 27, 2018 · 1 comment · Fixed by #1768 or #1845
Assignees
Labels
bug components Affects the `components` project

Comments

@IanLondon
Copy link
Contributor

overview

Can't type q/w/e into code blocks in styleguide

current behavior

HandleKeypress example in styleguide page prevents normal behavior of using keys

steps to reproduce

Type q/w/e in Component Styleguide while trying to modify a code block

expected behavior

q/w/e keys should type letters into the code blocks, not be ignored

@IanLondon IanLondon added bug components Affects the `components` project labels Jun 27, 2018
@mcous
Copy link
Contributor

mcous commented Jun 27, 2018

HandleKeypress prevents default on any keys that are handled. This is necessary for certain use-cases, but should likely be configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug components Affects the `components` project
Projects
None yet
2 participants