fix(protocol-designer): fix styles for SelectionRect #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectionRect fill color broke in CSS refactor, fix & update colors
IanLondon
added
ready for review
fix
Codecov Report
@@ Coverage Diff @@
## edge #1714 +/- ##
=======================================
Coverage 34.85% 34.85%
=======================================
Files 340 340
Lines 5563 5563
=======================================
Hits 1939 1939
Misses 3624 3624Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
SelectionRect fill color broke in an earlier CSS refactor, this PR fixes it & update colors to match the design (before it broke, it was slightly different eg had dashed stroke instead of solid stroke)
changelog
review requests
should match picture