Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix back to back manual move commands on desktop app #17129

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 17, 2024

Closes RQA-3728

Overview

Since the introduction of the move labware intervention deck map, chaining back to back move interventions has posed a challenge, see comments in #13005.

The setTimeout solution proposed in the linked PR effectively worked, and this code looks like it got dropped at some point. However, there are other ways of doing the same thing that are more React Spring-esque, using the API's reset property.

Current Behavior

2024-12-02_14-00-55.mp4

Fixed Behavior

Screen.Recording.2024-12-17.at.3.10.46.PM.mov

Test Plan and Hands on Testing

  • See video. Verified using QA's protocol probably like 20 times.

Changelog

  • Fixed back-to-back intervention modals sometimes moving labware to interesting places.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner December 17, 2024 21:27
@mjhuff mjhuff requested review from TamarZanzouri and a team and removed request for a team December 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant