feat(app): add instructional animations to manual move labware intervention modals #13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rogressMeter, clean up console logs
…modal to pass arguments for it
…nd use it in RunProgressMeter
…n order accordingly
…t contribute to broken animations
Codecov Report
@@ Coverage Diff @@
## edge #13005 +/- ##
==========================================
- Coverage 73.39% 72.69% -0.71%
==========================================
Files 2313 2369 +56
Lines 63157 64672 +1515
Branches 7027 7287 +260
==========================================
+ Hits 46356 47011 +655
- Misses 15142 15955 +813
- Partials 1659 1706 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ention modals Include react-spring to manage orchestration of performant async svg animations. Closes RLAB-316
b-cooper
changed the title
brenthagen
approved these changes
Jun 30, 2023
| // we can run into issues when there are 2 back to back move labware commands | ||
| // the modal never really un-renders and so the animations break after the first modal | ||
| // not really a fan of this, but haven't been able to fix the problem any other way | ||
| setTimeout(() => setShowInterventionModal(true), 0) |
There was a problem hiding this comment.
agreed this is not ideal but ok to merge and investigate later if it causes issues
There was a problem hiding this comment.
could think about attaching the intervention modal to a different component, for example. i think it's reasonable to display the modal if the user is anywhere on the run page
|
|
||
| return ( | ||
| <AnimatedSvg | ||
| viewBox={wholeDeckViewBox} |
There was a problem hiding this comment.
dropping a note here (for me, mostly) to look at viewbox dimensions when slot labels added later
mjhuff
added a commit
that referenced
this pull request
Dec 18, 2024
Closes RQA-3728 Since the introduction of the move labware intervention deck map, chaining back to back move interventions has posed a challenge, see comments in #13005. The setTimeout solution proposed in the linked PR effectively worked, and this code looks like it got dropped at some point. However, there are other ways of doing the same thing that are more React Spring-esque, using the API's reset property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Include react-spring to manage orchestration of performant async svg animations.
Closes RLAB-316
manualMoveLabwareAnimations.mov
Test Plan
Changelog
Review requests
Risk assessment