fix(protocol-designer): handle duplicate labware with a full deck #17083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a slot overflow is opened and duplicate labware is clicked, the action will fail silently if no room is left on the robot deck. Here, we use the `getNextAvailableDeckSlot` util to determine whether or not we can dispatch a labware duplication on the deck. If not, we keep the menu open, but render a snackbar letting the user know the reason for the failure. Note that according to new design paradigms, the button remains enabled in every case. Closes AUTH-1146
koji
reviewed
Dec 11, 2024
protocol-designer/src/pages/Designer/DeckSetup/SlotOverflowMenu.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Dec 11, 2024
protocol-designer/src/pages/Designer/DeckSetup/SlotOverflowMenu.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Dec 11, 2024
protocol-designer/src/pages/Designer/DeckSetup/SlotOverflowMenu.tsx
Outdated
Show resolved
Hide resolved
koji
approved these changes
Dec 11, 2024
jerader
reviewed
Dec 11, 2024
protocol-designer/src/pages/Designer/DeckSetup/SlotOverflowMenu.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Dec 11, 2024
protocol-designer/src/pages/Designer/DeckSetup/__tests__/SlotOverflowMenu.test.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Dec 11, 2024
What do you mean by this? |
@ncdiehl11 oh, its referring to my 1st comment - extending the util to grab the labware definition that is being duplicated |
jerader
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If a slot overflow is opened and duplicate labware is clicked, the action will fail silently if no room is left on the robot deck. Here, we use the
getNextAvailableDeckSlotutil to determine whether or not we can dispatch a labware duplication on the deck. If not, we keep the menu open, but render a snackbar letting the user know the reason for the failure. Note that according to new design paradigms, the button remains enabled in every case.Screen.Recording.2024-12-10.at.5.38.09.PM.mov
Closes AUTH-1146
Test Plan and Hands on Testing
Changelog
handleDuplicatefunctionReview requests
see test plan
Risk assessment
low-medium. relying on
getNextAvailableDeckSlotto handle full deck logic