-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): add announcement toast #16562
Conversation
add announcement toast close AUTH-876
also, a separate issue but the announcement modal needs to be updated to say 8.2.0 instead of 9.0.0 |
@@ -302,7 +302,7 @@ export const useAnnouncements = (): Announcement[] => { | |||
), | |||
}, | |||
{ | |||
announcementKey: 'redesign9.0', | |||
announcementKey: process.env.OT_PD_VERSION ?? 'redesign9.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm i am reluctant to use the OT_PD_VERSION here because it is for an announcementKey. I know that we don't see previous announcements but i think it is sort of for legacy tracking of the previous versions.
can this instead be:
announcementKey: 'redesign8.2'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean changing that manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerader <>
<NavigationBar />
<Kitchen>
<Box width="100%">
<AnnouncementModal />
<LabwareUploadModal />
<FileUploadMessagesModal />
<Routes>
{allRoutes.map(({ Component, path }: RouteProps) => {
return <Route key={path} path={path} element={<Component />} />
})}
<Route path="*" element={<Navigate to={landingPage.path} />} />
</Routes>
</Box>
</Kitchen>
</> |
@koji oh, i think we just have to remove line 66: which is AnnouncementModal, basically what i tested on your branch, the modal double renders. which we don't want. it should only render once you press the button in the toast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! good to merge after the checks are passing
Overview
add announcement toast
close AUTH-876
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low