feat(protocol-designer, components): analytics opt-in modal and footer #16561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
ncdiehl11 and
koji
and removed request for
a team
|
@jerader this is awesome! I think the button copy is swapped though. "Agree" should be the blue button on the right and "Reject" should be the sub-button on the left. |
koji
reviewed
Oct 23, 2024
koji
reviewed
Oct 23, 2024
Comment on lines
10
to
11
| // TODO(ja: 10/22/24): figure out the i18n stuff since components package.json does not have i18n and | ||
| // should not have i18n (since other projects use it). Due to the links, we would need access to both t and Trans |
There was a problem hiding this comment.
I guess we don't need to do this since basically text is passed to a component in ui components.
From my experience, if the components aren't published, looking for the way would be important but opentrons ui components are published so theoretically we should avoid using fixed text inside ui components.
I think this component itself is totally fine.
koji
reviewed
Oct 23, 2024
| // should not have i18n (since other projects use it). Due to the links, we would need access to both t and Trans | ||
| export function EndUserAgreementFooter(): JSX.Element { | ||
| return ( | ||
| <Flex |
There was a problem hiding this comment.
I think wrapping this by footer or creating a Footer with styled-component would be good.
const Footer = styled(footer)`
background-color: ${COLORS.grey20}
....
`
koji
approved these changes
Oct 23, 2024
jerader
force-pushed
the
pd_analytics-opt-in-stuff
branch
from
9055a23 to
b6aa06a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-967, AUTH-888, AUTH-792
Overview
Update the analytics opt-in modal, add it to the redesign, and add the footer to the landing page and overview page
Screen.Recording.2024-10-23.at.13.05.57.mov
Test Plan and Hands on Testing
see the analytics modal and the footer in the landing and overview pages
Changelog
Risk assessment
low